Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iOS): rewrite DRM Module #4136

Merged
merged 24 commits into from
Sep 20, 2024
Merged

feat(iOS): rewrite DRM Module #4136

merged 24 commits into from
Sep 20, 2024

Conversation

KrzysztofMoch
Copy link
Member

@KrzysztofMoch KrzysztofMoch commented Sep 2, 2024 •
edited
Loading

Summary

I have re-implemented DRM module for Apple devices. New Implementation use AVContentKeySession instead of resource loader.

fixes #4177 #3675 #3467

Motivation

Motivation is to fix issue with DRM Airplay and add visionOS support (in old implementation it was not possible)

Test plan

  • I have test app with Fairplay stream (which unfortunately I cannot share)
  • Also to play DRM content you need to have real device, simulator will not work

Tested on

  • iOS is tested by me
  • tvOS is not tested and I don't have real device to do it
  • visionOS is not tested and I don't have real device to do it

@moskalakamil moskalakamil mentioned this pull request Sep 2, 2024
Closed
@KrzysztofMoch KrzysztofMoch changed the title [WIP] feat(iOS): rewrite DRM Module feat(iOS): rewrite DRM Module Sep 4, 2024
@KrzysztofMoch KrzysztofMoch marked this pull request as ready for review September 4, 2024 15:58
@KrzysztofMoch
Copy link
Member Author

@freeboub should I add someone else to reviewers ?

@freeboub
Copy link
Collaborator

freeboub commented Sep 4, 2024

Maybe @paul-rinaldi or @paulrinaldi would like to test this version ? I can review but not test on my side ...

@freeboub
Copy link
Collaborator

freeboub commented Sep 4, 2024

I added some small comments, but it looks like good job 👍
If you are looking for other testers, you can try to ping last issue openers which are linked to DRM on ios. they may have a look to the PR or test it !

@paul-rinaldi
Copy link
Contributor

I added some small comments, but it looks like good job 👍
If you are looking for other testers, you can try to ping last issue openers which are linked to DRM on ios. they may have a look to the PR or test it !

I don't have a tv with iOS on it or vision OS. I have physical iPhones and physical iPads I could test with if you would like me to but it sounds like the PR creator already did that.

Sorry I could not be more helpful.

@freeboub
Copy link
Collaborator

freeboub commented Sep 4, 2024

I added some small comments, but it looks like good job 👍
If you are looking for other testers, you can try to ping last issue openers which are linked to DRM on ios. they may have a look to the PR or test it !

I don't have a tv with iOS on it or vision OS. I have physical iPhones and physical iPads I could test with if you would like me to but it sounds like the PR creator already did that.

Sorry I could not be more helpful.

My proposal was linked to your message on discord in fact !

@rohankm
Copy link

rohankm commented Sep 6, 2024

I added some small comments, but it looks like good job 👍
If you are looking for other testers, you can try to ping last issue openers which are linked to DRM on ios. they may have a look to the PR or test it !

I have tested it and it works fine also it solved buffering issues in drm videos.

freeboub
freeboub reviewed Sep 6, 2024
View reviewed changes
src/Video.tsx Show resolved Hide resolved
@freeboub
Copy link
Collaborator

freeboub commented Sep 6, 2024

Looks good to me. Please build a release after merging this PR :)

@KrzysztofMoch
Copy link
Member Author

Sure I will give this PR to tests for our client and after it will do it! Thanks!

@freeboub freeboub mentioned this pull request Sep 9, 2024
Open
4 tasks
@freeboub freeboub mentioned this pull request Sep 17, 2024
Closed
@rohankm
Copy link

rohankm commented Sep 18, 2024

Waiting for the merge

freeboub
freeboub reviewed Sep 18, 2024
View reviewed changes
ios/Video/RCTVideo.swift Outdated Show resolved Hide resolved
@freeboub freeboub self-requested a review September 18, 2024 14:35
@maksymhcode-care
Copy link

Is this ready to be merged?

freeboub
freeboub reviewed Sep 19, 2024
View reviewed changes
ios/Video/RCTVideo.swift Outdated Show resolved Hide resolved
freeboub
freeboub reviewed Sep 19, 2024
View reviewed changes
ios/Video/RCTVideo.swift Outdated Show resolved Hide resolved
@KrzysztofMoch KrzysztofMoch merged commit 0e4c95d into TheWidlarzGroup:master Sep 20, 2024
9 checks passed
@KrzysztofMoch KrzysztofMoch deleted the feat/ios-rewrite-drm branch September 28, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agastiazoro agastiazoro agastiazoro left review comments

@freeboub freeboub freeboub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: IOS DRM Custom License Request Not Working
6 participants
@KrzysztofMoch @freeboub @paul-rinaldi @rohankm @maksymhcode-care @agastiazoro